The shielding all needs to be grounded, and you need shielding on the underside of the control covers. It's normal to run the shielding up over the edge of the control cavity onto the rebate for the cover. The control cavity shielding is grounded by contact with the pots, and the shielding on the underside of the cover is grounded by contact with the shielding in the rebate.

The two pickup cavities will need a grounding wire run between them and back to ground in the control cavity.

Use a multimeter to check continuity to all the areas of shielding, and stick some more foil across and gaps or areas with poor continuity.