Grounding is often misunderstood... even by the so called experts..
... 1/ A soldered ground wire jumping from pot to pot helps to ensure a reliable ground connection under almost every cicumstance. You may have fully shielded your control cavity but that loose nut on the volume pot will make an awful noise if nil wire is used to permanently bond the earth connections together. And we all know how often volume pots become loose...
... 2/ Ground loops. Ideally we want to connect earth's or grounds in a star pattern, with all the 'radials' coming back to a single central point which is then subsequently connected through to our pedals and on to our amp. Any 'earth loop' you create anywhere only becomes a problem when a real and tangible AC or DC current passes through any portion of that loop, so in the case of earth loops in the shielding within the body of a guitar there is nil real DC or AC current in that copper shielding you so carefully fitted so there should be nil problem. Between your pedals and your amp, yep there is AC (your guitar signal), and then there is DC in the daisy chain power cable feeding power to your pedals so there is plenty of opportunity for the problem of earth loop or ground loop noise.
... 3/ Shielding when done correctly is never a waste of time.
... 4/ Over shielding (shielding everything in existence simply because you can) can lead to some issues. The biggest issue being the loss of high frequencies. Every shielded cable has capacitance from the centre conductor to the shield. The more shielded cable you have the more capacitance is there to suck away your higher frequencies just like your tone knob does when wound out down. There are times you need shielded cable to protect your (unbalanced) signal from interference so you will need to use it, the rest of the time try to avoid it if you can so that the higher frequencies of your awesome axe will actually be able to get to your amp.
... 5/ Grounding one end. This is a huge topic, bigger than this reply should go, but within a guitar the grounding of only one end of a shielded cable is generally not needed or preferred. You do need to have a circuit for things to work so you will need to be able to chase a continuity path from the centre pin of your guitar jack through all the parts of the guitar and then back to the sleeve connection of the guitar jack, and if that means using the shield of a cable to get from one place to another within the guitar then it must be done. On a shielded balanced line microphone cable used in a PA it is often done that only one end of the shield is connected (usually the source end), and inside a guitar amp the technique is quite often found to minimise stray signal pick up from other active components inside the amp, but inside a guitar it is rare and only done in certain cases due to very specific issues and if nothing else works.
As I said before there must be some DC or AC component on a part of any earth/ground loop for any negative issue to manifest. If you wire your earth/ground from your jack to a conveniently located pot, and then wire from that pot out to each location that requires an earth/ground connection then you will maximise your protection from 'interference' and minimise all those other issues. And follow the KISS principal ... 'Keep It Simple'...