Thanks Simon, very helpful as usual. I did the continuity (beep) test on the switch and it seems ok. Sound from the pickups is patchy when I tap with a small screwdriver. At the moment the bridge pickup is dead. Volume and tone controls seem to work as best as I can tell. I have tested all connections with the beep test and they check out ok. I did have to join onto the pickup wires both earth and hot wire. Double checked those soldered joins and they appear ok. I'm a bit puzzled???