The wiring will certainly work.

It is more normal to have the input and output wires on the volume pot the other way round, so the output is on the central (wiper) tab. Having it your way around alters the way the taper works slightly, so volume reduction may not be quite as smooth. It's the way you'd wire up the volume pot if you had two volume controls for two pickups, but no selector switch (e.g. on a lot of Jazz bases), so that you can turn one volume all the way down without also grounding the sound from the other pickup.

The tone pot is connected to the output, but with this wiring arrangement I don't know if this creates the same effect as on 'vintage' Gibson wiring, giving a more interactive tone pot so that it also alters the volume a bit when used, as well as keeping the signal treble level up when the volume control is turned down.

No right or wrong with this, just user preference.

Guitar looks great. I don't normally like that sort of finish but on this it looks good. I quite like the white buttons. Certainly easier to see against the black headstock if tuning up on a dark stage.