Quote Originally Posted by jugglindan View Post
McCreed is correct and I am not. My apologies but I have led you astray by not checking the logic of the DiMarzio diagram. I just assumed that since it was indexed under "2 humbucker, 3-way switch, 1 volume, 1 tone, neck, neck/bridge, bridge" that it would be the correct diagram. I think the DiMarzio diagram is incorrect, and that you wired it up perfectly. Here is my analysis diagram. Green dots indicate the lugs that are connected on that side of the switch for each position, red dots indicate the lugs that are connected on the other bank. The top row of diagrams shows the result for each blade position using the DiMarzio wiring. The bottom row corrects the mistakes.
Click image for larger version. 

Name:	dimarzio diagram decoded.png 
Views:	529 
Size:	83.0 KB 
ID:	34662

However, you can see that all that is required is one extra link on each side for the middle switch position to select both pickups. So if your friend ever returns the guitar it will be easy to fix.

Plus you should be pleased that you followed the diagram perfectly, it's the DiMarzio switch wiring that is wrong. My apologies once again for that.
No need to apologise mate your help is greatly appreciated. It is a bit difficult to understand your new diagram without the guitar here now but I think what you are saying is I just need to add a wire on each side to get both pickups working in the middle position.

I will see if I can get him to drop the guitar back over in the next couple of days and try to fix it. I will take a picture of the wiring if he does bring it back because I want to do it correctly.

It will be helpful for me to understand this for the future because I'll probably build a seven string at some stage

Cheers,
Alkay