Thanks for your reply. I was concerned the pot was broken, so I rewired it to the way it was before to test it, and it is working again. There seems to be some changes now, the first control doesn't turn the volume all the way off any more, perhaps thinning the solder has corrected this connection with the green and bare wire? Now the second control is only loudest at the mid point when the first control is turned all the way up, if it is low, then the second control gets louder in a linear sort of way (I guess the way its meant to). Tone control still makes subtle changes, but they're more noticeable if one or both of the volume controls is lower.

Do you think this is the way it is, or meant to be?

If I wanted to replace the pots is this the one I would need: https://www.gear4music.com/Guitar-an...RoCLEUQAvD_BwE

Thanks again for your help